Support calibration under independent censoring - #298
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 12, 2026 12:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
censoring_heuristic="adjusted"when censored observations are present1 - KMwithout competing events)polarstateandpseudostateunchangedWhy
Time-dependent calibration previously rejected adjusted censoring whenever censored observations were present. Under independent censoring within the prediction groups/range, Aalen–Johansen/Kaplan–Meier estimates provide the appropriate observed risks, while AJ pseudo-observations support smoothing.
pseudostatecurrently requires Python 3.13 while rtichoke supports Python 3.9+, so this PR performs the same leave-one-out AJ calculation internally using the existingpolarstatedependency. The adapter can be replaced later if package version constraints align.Validation
36 passedlifelines.KaplanMeierFitterlifelines.AalenJohansenFitterruff check src tests: passedtycheck for changed files: passed