Allow adjusted calibration when censoring is absent - #297
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
censoring_heuristic="adjusted"increate_calibration_curve_times()when the supplied outcome data contain no censored observationscensoring_heuristic="adjusted"when any censored observations are presentcompeting_heuristic="adjusted_as_censored"behavior unchangedValueErrorWhy
When there are no censored observations, the censoring heuristic is statistically irrelevant. Rejecting
"adjusted"purely because of its label creates an unnecessary API asymmetry with the other_timescurves. Actual adjusted calibration under censoring remains unsupported and is deliberately not implemented in this PR.Validation
The focused
tests/test_calibration_times.pysuite passed after applying both the public validation change and the matching internal-loop change.