Publish 0.1.29 through configured trusted publisher - #296
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
.github/workflows/python-package.yml, matching the workflow identity already configured as the PyPI trusted publisher.github/release-versionmarker changing onmain, so ordinary pushes still do not publishrelease.yml, whose OIDC token PyPI correctly rejected because that workflow was not the configured trusted publisherWhy
The attempted
release.ymlpublish reached PyPI but failed withinvalid-publisher: the token was valid, but itsjob_workflow_refdid not match the publisher configured for the project. The historical successful publisher ispython-package.yml.Release
This PR adds
.github/release-versionwith0.1.29. Its merge commit will therefore trigger the release job exactly once and publish the already-bumpedrtichoke==0.1.29. Future releases require intentionally changing both the package version and this marker.