Raise actionable errors for unsupported calibration heuristics - #293
Merged
Conversation
Contributor
|
uriahf
marked this pull request as ready for review
August 11, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
create_calibration_curve_times()currently skips internallycensoring_heuristic='adjusted'andcompeting_heuristic='adjusted_as_censored'No data remaining after applying heuristics and time horizons.errorrtichokecalibration imports through the calibration package API so the validation applies to the documented public entry pointadjustedcaseWhy
The current implementation deliberately skips those heuristic choices, but the final error describes an empty-data symptom rather than the unsupported input that caused it. This PR makes the existing contract explicit without changing calibration statistics or choosing a new default.
Scope
This PR does not add a default
heuristics_setsvalue. Choosing a calibration-specific default is a separate API/statistical decision and should not be bundled with error handling.