Skip to content

Raise actionable errors for unsupported calibration heuristics - #293

Merged
uriahf merged 7 commits into
mainfrom
agent/calibration-heuristic-validation
Aug 12, 2026
Merged

Raise actionable errors for unsupported calibration heuristics#293
uriahf merged 7 commits into
mainfrom
agent/calibration-heuristic-validation

Conversation

@uriahf

@uriahf uriahf commented Aug 11, 2026

Copy link
Copy Markdown
Owner

What changed

  • adds early validation for heuristic combinations that create_calibration_curve_times() currently skips internally
  • raises a targeted error for censoring_heuristic='adjusted' and competing_heuristic='adjusted_as_censored'
  • points users to a supported combination instead of allowing all horizons to be skipped and ending with the generic No data remaining after applying heuristics and time horizons. error
  • routes the top-level rtichoke calibration imports through the calibration package API so the validation applies to the documented public entry point
  • adds a regression test for the previously silent adjusted case

Why

The current implementation deliberately skips those heuristic choices, but the final error describes an empty-data symptom rather than the unsupported input that caused it. This PR makes the existing contract explicit without changing calibration statistics or choosing a new default.

Scope

This PR does not add a default heuristics_sets value. Choosing a calibration-specific default is a separate API/statistical decision and should not be bundled with error handling.

@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-12 06:14 UTC

@uriahf
uriahf marked this pull request as ready for review August 11, 2026 16:36
@uriahf
uriahf merged commit d71f40f into main Aug 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant