Fix calibration multi-population input contract - #291
Merged
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290.
What changed
_make_deciles_dat_binary()so matchingprobs/realsdictionary keys are paired population-by-populationRoot cause
The binned calibration helper treated every probability vector as though it had to span the sum of all population sizes. That conflicted with the natural keyed representation already used elsewhere in calibration:
Scope
This PR intentionally makes only the changes needed for #290. It does not introduce a new calibration module or normalization layer, and it does not address the separate time-heuristic or integer-horizon issues.
Validation
The regression tests cover unequal-size populations for both ordinary calibration rendering modes and for
create_calibration_curve_times(). GitHub Actions runs the repository test and documentation workflows.