Sort performance data deterministically - #287
Merged
Merged
Conversation
uriahf
marked this pull request as ready for review
August 11, 2026 12:45
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
prepare_performance_data()output byreference_group,stratified_by, andchosen_cutoff.group_by/pivotoutput order.Why
The R implementation constructs probability thresholds in ascending order, so its public performance data is naturally ordered. The Python implementation aggregates with Polars and previously returned the resulting incidental row order. This change restores predictable R/Python parity for consumers inspecting or using the performance table.
Scope
This intentionally changes only the public return ordering; metric calculations are untouched.