Skip to content

Tighten browser summary report layout for RMarkdown parity - #225

Merged
uriahf merged 3 commits into
mainfrom
fix/browser-report-density-parity-13317718407801580901
Aug 30, 2026
Merged

Tighten browser summary report layout for RMarkdown parity#225
uriahf merged 3 commits into
mainfrom
fix/browser-report-density-parity-13317718407801580901

Conversation

@uriahf

@uriahf uriahf commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary of changes

  1. Baseline SHA / Version:

    • Starting main SHA: d4b71aa89326491ffc7363bf9daa61bb39d36341
    • Package version: 0.0.7
    • Vendored rtichoke_viz version: 0.15.0 (unmodified)
  2. Exact CSS/Layout Differences Changed:

    • Scoped .rtichoke-report max-width to 1040px (previously 1200px).
    • Scoped embedded chart heights: .rtichoke-report .rtichoke-viz-chart set to 500px min-height/height (previously 600px), .rtichoke-report .rtichoke-calibration set to 550px min-height/height.
    • Tightened report vertical gaps scale:
      • Report (.rtichoke-report): 1.5rem
      • Section (.rtichoke-report__section): 1.25rem
      • Group (.rtichoke-report__group): 0.875rem
      • Component & Tabpanel (.rtichoke-report__component, .rtichoke-report__tabpanel): 0.5rem
  3. Resulting Report Width: 1040px

  4. Resulting Embedded Chart Heights: 500px (ROC, Lift, PR, Gains, Decision Curve, IA), 550px (Calibration)

  5. Resulting Spacing Values: 1.5rem / 1.25rem / 0.875rem / 0.5rem

  6. Confirmation Standalone Charts Are Unaffected: Verified that standalone .rtichoke-viz-chart widgets outside summary reports preserve default sizing.

  7. Tests Added/Updated:

    • tests/testthat/test-report-browser.R: Updated HTML tag assertions for density CSS rules.
    • tests/testthat/test-summary-report-browser.R: Updated headless browser test assertions for max-width and chart heights.
  8. Validation Results: All tests and SHA256 integrity verifications passed.

  9. Files Changed:

    • R/report_browser.R
    • tests/testthat/test-report-browser.R
    • tests/testthat/test-summary-report-browser.R

PR created automatically by Jules for task 13317718407801580901 started by @uriahf

Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 2 commits August 30, 2026 01:43
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
@uriahf
uriahf merged commit 102d203 into main Aug 30, 2026
6 of 7 checks passed
github-actions Bot added a commit that referenced this pull request Aug 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant