Tighten browser summary report layout for RMarkdown parity - #225
Conversation
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Co-authored-by: uriahf <11351434+uriahf@users.noreply.github.com>
Summary of changes
Baseline SHA / Version:
mainSHA:d4b71aa89326491ffc7363bf9daa61bb39d363410.0.7rtichoke_vizversion:0.15.0(unmodified)Exact CSS/Layout Differences Changed:
.rtichoke-reportmax-width to1040px(previously1200px)..rtichoke-report .rtichoke-viz-chartset to500pxmin-height/height (previously600px),.rtichoke-report .rtichoke-calibrationset to550pxmin-height/height..rtichoke-report):1.5rem.rtichoke-report__section):1.25rem.rtichoke-report__group):0.875rem.rtichoke-report__component,.rtichoke-report__tabpanel):0.5remResulting Report Width:
1040pxResulting Embedded Chart Heights:
500px(ROC, Lift, PR, Gains, Decision Curve, IA),550px(Calibration)Resulting Spacing Values:
1.5rem/1.25rem/0.875rem/0.5remConfirmation Standalone Charts Are Unaffected: Verified that standalone
.rtichoke-viz-chartwidgets outside summary reports preserve default sizing.Tests Added/Updated:
tests/testthat/test-report-browser.R: Updated HTML tag assertions for density CSS rules.tests/testthat/test-summary-report-browser.R: Updated headless browser test assertions for max-width and chart heights.Validation Results: All tests and SHA256 integrity verifications passed.
Files Changed:
R/report_browser.Rtests/testthat/test-report-browser.Rtests/testthat/test-summary-report-browser.RPR created automatically by Jules for task 13317718407801580901 started by @uriahf