fix: show GLOBAL OPTIONS in SubcommandHelpTemplate#2359
Open
dearchap wants to merge 2 commits into
Open
Conversation
SubcommandHelpTemplate was missing the VisiblePersistentFlags section, so subcommands with their own subcommands would not display GLOBAL OPTIONS when help was shown via ShowSubcommandHelp. This aligns SubcommandHelpTemplate with CommandHelpTemplate, which already includes the GLOBAL OPTIONS section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds the
VisiblePersistentFlags/GLOBAL OPTIONSsection toSubcommandHelpTemplate, matching whatCommandHelpTemplatealready has.When a subcommand has its own subcommands,
DefaultShowSubcommandHelpusesSubcommandHelpTemplateto display help. This template was missing the GLOBAL OPTIONS section, so persistent flags (flags defined on parent commands) were not shown.This affected the
subcommand --helpcase when the subcommand also has subcommands, AND thesubcommand(with no args) help case.Which issue(s) this PR fixes:
Fixes #2076
Special notes for your reviewer:
Only
template.gowas modified — theSubcommandHelpTemplatevar.Release Notes