docs: fix broken links in CHANGELOG.md#2357
Open
dearchap wants to merge 3 commits into
Open
Conversation
- Remove links to @lynncyrin and @masonj188 GitHub profiles (404) - Fix urfave/891 → /pull/891 (typo, missing cli/pull) - Fix compare ref v1 → v1-maint (nonexistent tag)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes the remaining broken links in
docs/CHANGELOG.mdidentified in #1939:@lynncyrinand@masonj188GitHub profiles (both return 404 — accounts likely deleted)urfave/891→urfave/cli/pull/891(typo, missingcli/pullin path)v1→v1-maint(v1 tag doesn't exist, branch isv1-maint)Which issue(s) this PR fixes:
Fixes #1939
Special notes for your reviewer:
Only
docs/CHANGELOG.mdwas modified.Testing
Verified each fixed URL returns HTTP 200:
https://github.com/urfave/cli/pull/891https://github.com/urfave/cli/compare/v1.22.4...v1-maintRelease Notes