Reject v1-style flag aliases#2351
Closed
ibobgunardi wants to merge 1 commit into
Closed
Conversation
0860150 to
51f436d
Compare
Author
|
Checked the red jobs after the update.
I am leaving the binary-size threshold alone here so this PR stays focused on #1103. |
Contributor
|
@ibobgunardi v2 is in maint with only security patches. |
Author
|
Thanks, that makes sense. This is not security-related, so I'm closing it rather than keeping a v2-maint PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1103.
This makes the v2 branch fail fast when a built-in flag is still written with the old v1-style Name value, for example Name: "config, cfg" or Name: "config cfg". The error points developers to Aliases instead of silently registering only the first name.
I also updated two existing tests that were still using the old form so they keep testing aliases through the supported API.
Tests: