Issue#2323#2345
Open
MohitPanchariya wants to merge 6 commits into
Open
Conversation
dearchap
reviewed
Jun 5, 2026
|
|
||
| {{$key}}: | ||
| {{$value}} | ||
| {{- end}}` |
Contributor
There was a problem hiding this comment.
Suggested change
| {{- end}}` | |
| {{end}}` |
dearchap
reviewed
Jun 5, 2026
Contributor
dearchap
left a comment
There was a problem hiding this comment.
@MohitPanchariya I like this PR . Its very clean and backward compatible. However I am more worried about side effects of a special case like this. People will start adding more and more things like this throughout the template. Do you see lots of people using this or is this a one off for convenience ? Strictly speaking users can remap the template to whatever they'd like.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
(REQUIRED)
What this PR does / why we need it:
(REQUIRED)
ExtraInfofield,but that requires using a custom template. Its a bit cumbersome to use custom templates from a
users perspective just to print additional help topics.
help templates to conditionally render additional help topics.
Which issue(s) this PR fixes:
Fixes #2323
(REQUIRED)
Testing
(fill-in or delete this section)
Added unit tests to test additional help topics.
Release Notes
(REQUIRED)