http: actually unlink first item; return early - #1071
Draft
dozreg-toplud wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
Huh? Can't reproduce the crash with |
This reverts commit 9af8990.
Contributor
Author
dozreg-toplud
marked this pull request as draft
July 30, 2026 11:52
Contributor
Author
|
Let's get #1072 merged first, then I'll rebase to run the CI with UB fixes, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the first element of the linked list
htp_u->htd_u->htp_uwas the element we wanted to unlink, then the function would noop.Also, if an element got unlinked, we would keep iterating over the linked list instead of returning early. I am assuming that the linked list does not hold duplicate entries.
There is potential for more optimizations: if the linked list is guaranteed to hold
htp_uthen the while loop could be made unconditional, removing extra checks. Though I do not know if this actually holds.