vere: avoid gc-loop after hitting guard page at home - #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recover: top: meme(ie,u3m_signal(c3__meme)on the home road) sets theu3o_check_corruptflag, which leads to a full gc in mars after the next global state mutation. This feature, while questionable, does correctly clear up memory leaks (at least in many scenarios) that were caused by abandoning the computation that caused the guard page to be hit. But it doesn't reset the flag, so gc passes are repeated after every subsequent mutation. The PR just unsets the flag after gc.Our overall approach to OOM-on-the-home-road should be reevaluated, as this feature is only active through the
u3m_signal()codepath --u3m_bail()on the home road is simply a fatal error.