jets: refcount fixes caught by a linter - #1058
Merged
Merged
Conversation
dozreg-toplud
force-pushed
the
dozreg/more-refcount-fixes
branch
from
July 20, 2026 19:52
536e2f2 to
60fa7cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refcount bugs caught by a linter (WIP):
bytestream.c: we lose retainedocts_list;wid, didn't testwidanddatfor being atomsoutfor being a direct atom even though the code clearly assumes it; missing c3_w -> atom conversionscand owneddassumptions thatbetter fix is to just get rid of leaks by not having generic macrosnumnameis a direct atom (so nou3k(year)) but no checks;run_once, saner control flow which is more readable for a linter and a human;u3z_uniq: leakedkeyloss.c: an atom was used as direct with no check