Conversation
ytkimirti
added this pull request to stack #26
September 28, 2026 05:51
ytkimirti
marked this pull request as ready for review
September 28, 2026 05:51
…93-presign # Conflicts: # README.md
CahidArda
approved these changes
Sep 29, 2026
CahidArda
requested changes
Sep 29, 2026
CahidArda
left a comment
CahidArda
left a comment
Collaborator
There was a problem hiding this comment.
realized this is the last PR in a stack, I haven't checked the other prs yet
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The SDK behavior, CLI validation, documentation, and dependency lockfile are consistent with the secure presigning change.
Review effort: Balanced
Findings: None
What changed in this PR
Updates Blob presigning to use Upstash’s secure signing service with a 10-minute limit.
Changes:
- Upgrades
@upstash/blobto 0.0.7. - Caps and defaults presigned URLs to 600 seconds.
- Updates validation, help text, tests, and README examples.
| File | Description |
|---|---|
src/commands/blob/presign.ts |
Applies the new expiration limit and messaging. |
tests/unit/blob-s3.test.ts |
Tests rejection above 600 seconds. |
README.md |
Updates the presign example. |
package.json |
Upgrades the Blob SDK. |
package-lock.json |
Locks the upgraded dependency. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Sep 29, 2026
CahidArda
reviewed
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades @upstash/blob to 0.0.7, which signs URLs through Upstash's /v1/presign instead of locally with the bucket's temporary credential, so URLs no longer leak a whole-bucket credential.
blob presignnow defaults to and allows at most 600 seconds (the new cap), and its help and README no longer say links are bounded by the credential.