🔒 Update js-yaml, brace-expansion, lodash, handlebars (lockfile v1) - #184
Merged
Merged
Conversation
Dependabot PRs #182, #174, #169, #168 each regenerated package-lock.json to lockfileVersion 3, which breaks npm ci under the repo's Node 14 / npm 6 CI target with: npm ERR! Cannot read property '@actions/core' of undefined This maintainer-owned replacement preserves lockfileVersion 1 while applying the security fixes: - js-yaml 3.14.0 -> 3.15.2 (GHSA backports) - brace-expansion 1.1.11 -> 1.1.18 - lodash 4.17.20 -> 4.18.1 - handlebars 4.7.6 -> 4.7.9 Also fixes the lockfile name from 'github-actions-starter' to '@upptime/updates' to match package.json. Supersedes #182 #174 #169 #168.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lockfileVersion: 1— the Dependabot branches each regeneratedpackage-lock.jsonto lockfileVersion 3, which breaksnpm ciunder the repo's Node 14 / npm 6 CI target withnpm ERR! Cannot read property '@actions/core' of undefined(see failing "Build and test" checks on those PRs)namefield (github-actions-starter→@upptime/updates) to matchpackage.jsonSupersedes #182, #174, #169, #168.
Test Plan
npm cipasses with Node 14.21.3 / npm 6.14.18 (the CI target)npm run build(tsc) passesnpm run test(jest, 2 tests) passeslockfileVersion: 1; diff limited to the four dependency entries (+ minor neo-async range bump inside handlebars and optional flags on fsevents-tree dev deps)