Fix octree raycast fallback dropping inside-origin hits under tight maxDistance - #1155
Open
untoldengine wants to merge 1 commit into
Open
Fix octree raycast fallback dropping inside-origin hits under tight maxDistance#1155untoldengine wants to merge 1 commit into
untoldengine wants to merge 1 commit into
Conversation
… tight maxDistance OctreeSystem.query's own maxDistance cull compares against its sorted ray-AABB distance, which for an inside-origin box is the far EXIT distance, not the true hit distance. A short raycast whose origin sits inside a large registered AABB would get that box dropped before PhysicsQuery's narrow phase ever recomputed the correct entry distance (0, per the documented inside-the-box contract) — reporting a miss instead of the real hit. The query is now asked for the unbounded fallback distance instead of the caller's maxDistance; the narrow phase already enforces the real cap correctly, against the recomputed entry distance. For outside-origin candidates (where the broad-phase distance already equals the true hit distance) this changes nothing but which phase does the filtering. Adds a regression test with a tight maxDistance smaller than the containing box's exit distance; verified it fails against the previous code and passes now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.