Skip to content

fix: make cli compatible with kernel changes#48

Merged
rupertsworld merged 1 commit into
mainfrom
fix/cli
Aug 1, 2025
Merged

fix: make cli compatible with kernel changes#48
rupertsworld merged 1 commit into
mainfrom
fix/cli

Conversation

@rupertsworld
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings August 1, 2025 01:57
@rupertsworld rupertsworld merged commit 8306dd7 into main Aug 1, 2025
1 check failed
@rupertsworld rupertsworld deleted the fix/cli branch August 1, 2025 01:57
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CLI to be compatible with recent kernel changes by replacing the deprecated Interpreter and Runtime classes with the new unified Kernel class. The changes simplify the code structure while maintaining the same functionality.

Key changes:

  • Replace Interpreter and Runtime with unified Kernel class
  • Update event listener names to match new kernel API
  • Remove redundant message state updates

});
}, []);

function sendMessage(msg: Message) {
Copy link

Copilot AI Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The setMessages call was removed from sendMessage function, but it's still present in the message event handler. This creates inconsistent state update patterns - messages are only updated when the kernel emits an event, not immediately when sending. Consider if immediate state update is needed for better UX.

Suggested change
function sendMessage(msg: Message) {
function sendMessage(msg: Message) {
setMessages((prevMessages) => [...prevMessages, msg]);

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants