feat: Losen dependency between @unikraft/cloud and plugins - #11
Merged
Merged
Conversation
Signed-off-by: aabedraba <abdallah@unikraft.com>
There was a problem hiding this comment.
馃數 Needs a closer look
The broad generated-client and build/dependency changes warrant final human review.
Pull request overview
This PR decouples generated plugin clients from @unikraft/cloud through a standalone transport contract.
Changes:
- Adds
Transport,RequestArgs, andCallOptionsinterfaces. - Routes generated clients through injected transports.
- Removes SDK dependency and related build configuration.
- Updates documentation and publishing checks.
File summaries
| File | Summary |
|---|---|
js/tools/tsplugingen/templates/transport.ts.tmpl |
Defines the transport contract. |
js/tools/tsplugingen/templates/resources.tmpl |
Uses injected transports for requests. |
js/tools/tsplugingen/templates/README.md.tmpl |
Documents transport-based usage. |
js/tools/tsplugingen/templates/package.json.tmpl |
Removes the SDK peer dependency. |
js/tools/tsplugingen/templates/index.ts.tmpl |
Injects and validates transports. |
js/tools/tsplugingen/static/tsconfig.json |
Adds DOM typings for AbortSignal. |
js/tools/tsplugingen/sdk-range.sh |
Removes SDK range derivation. |
js/tools/tsplugingen/README.md |
Updates architecture and build documentation. |
js/tools/tsplugingen/publish-check.sh |
Updates source-change messaging. |
js/tools/tsplugingen/Makefile |
Removes SDK installation and configuration coupling. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
nderjung
approved these changes
Sep 17, 2026
nderjung
left a comment
nderjung
left a comment
Member
There was a problem hiding this comment.
Thanks!
Reviewed-by: Alexander Jung alex@unikraft.com
Approved-by: Alexander Jung alex@unikraft.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the work of:
unikraft-cloud/js-sdk#34
https://github.com/unikraft-cloud/plugins/pull/29
Replaces dependency with
@unikraft/cloudwith interfaces to the transport layer in the SDK.Signed-off-by: aabedraba abdallah@unikraft.com