feat: Support building the CLI for js/wasm - #493
Draft
craciunoiuc wants to merge 1 commit into
Draft
craciunoiuc wants to merge 1 commit into
craciunoiuc wants to merge 1 commit into
Conversation
The CLI did not compile for GOOS=js GOARCH=wasm, so the dashboard could not run it in the browser. The build graph reached BuildKit, containerd, Docker, Bubble Tea, a machine fingerprint and a large generated IATA table, none of which the wasm backend accepts. Commands that need a local daemon, terminal or filesystem now split into `!js` and `js` files. The js side keeps the kong structs, so help output is unchanged, and reports that the command belongs to the native CLI. A `wasm` task builds and compresses the module. Signed-off-by: Cezar Craciunoiu <cezar@unikraft.io>
Contributor
Author
|
Summary of the call:
Bonus:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI did not compile for GOOS=js GOARCH=wasm, so the dashboard could not run it in the browser. The build graph reached BuildKit, containerd, Docker, Bubble Tea, a machine fingerprint and a large generated IATA table, none of which the wasm backend accepts.
Commands that need a local daemon, terminal or filesystem now split into
!jsandjsfiles. The js side keeps the kong structs, so help output is unchanged, and reports that the command belongs to the native CLI. Awasmtask builds and compresses the module.Not yet ready for review