Conversation
Contributor
Author
|
@markusicu, the fixes are not trivial, and would look like this. I can go ahead and create another pull request for the C bidi implementation, but you definitely need an owner on the ICU side to review and own this. It can't be me. |
roozbehp
marked this pull request as draft
September 17, 2026 23:53
Contributor
Author
|
Converting to draft in favor of smaller more-reviewable changes. |
Contributor
Author
|
Fix for the easier case at #4205 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
J1: Apply the active directional override to PDI as required by X6a,
while retaining its isolate identity for X10 and whitespace treatment for L1.
J2: Enforce BD16's limit of 63 pending opening brackets. On overflow,
discard all pairs in that isolating run sequence, including earlier pairs.
Track BD16 separately from ICU's N0 state; reprocess only when overflow
requires undoing earlier bracket resolutions.
Add regression tests for both issues, including matched/unmatched PDIs,
L1 line endings, the 63/64 boundary, canonical bracket equivalents,
isolating run sequence boundaries, contextual paragraphs and streaming.
Checklist