Skip to content

ICU-23310 Add U_LIFETIME_BOUND annotations for unistr.h et al. - #4176

Merged
roubert merged 2 commits into
unicode-org:mainfrom
roubert:23310-unistr
Sep 10, 2026
Merged

roubert merged 2 commits into
unicode-org:mainfrom
roubert:23310-unistr

Conversation

@roubert

@roubert roubert commented Sep 9, 2026

Copy link
Copy Markdown
Member

Checklist

  • Required: Issue filed: ICU-23310
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

ALLOW_MANY_COMMITS=true

@roubert
roubert marked this pull request as ready for review September 9, 2026 15:35
@roubert
roubert requested a review from eggrobin September 9, 2026 15:35

@eggrobin eggrobin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Feel free to do add the additional utext_open bounds in a subsequent PR if that’s more convenient.

Comment thread icu4c/source/common/unicode/utext.h
Comment thread icu4c/source/common/utext.cpp
@roubert

roubert commented Sep 10, 2026

Copy link
Copy Markdown
Member Author

I'll keep those comments unresolved here and go back to them later.

@roubert
roubert merged commit 2d804af into unicode-org:main Sep 10, 2026
98 checks passed
@roubert
roubert deleted the 23310-unistr branch September 10, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants