ICU-23486 Improve clarity of getOperator assertion - #4119
Merged
Merged
Conversation
Contributor
Author
Member
Please try again. |
Contributor
Author
markusicu
approved these changes
Aug 27, 2026
markusicu
left a comment
Member
There was a problem hiding this comment.
thanks -- should work either way, but this is more readable
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Member
|
rebased to recent ICU main to try to get past the msys2 check failure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This clarifies the assertion condition in what used to rely on an implicit operator. This caused compilation failures on FreeBSD 15-STABLE for a while. While the strict assertion sanitizer has been reverted upstream, I think this is clearer, so I'm opening this PR.
Refer to the Jira ticket for a fuller background.
Checklist