Skip to content

ICU-23486 Improve clarity of getOperator assertion - #4119

Merged
markusicu merged 1 commit into
unicode-org:mainfrom
ianthetechie:main
Sep 14, 2026
Merged

markusicu merged 1 commit into
unicode-org:mainfrom
ianthetechie:main

Conversation

@ianthetechie

@ianthetechie ianthetechie commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

This clarifies the assertion condition in what used to rely on an implicit operator. This caused compilation failures on FreeBSD 15-STABLE for a while. While the strict assertion sanitizer has been reverted upstream, I think this is clearer, so I'm opening this PR.

Refer to the Jira ticket for a fuller background.

Checklist

  • Required: Issue filed: ICU-23486
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-NNNNN Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable
  • Approver: Feel free to merge on my behalf

@ianthetechie

Copy link
Copy Markdown
Contributor Author
image

I've tried to accept the CLA several times but it seems the app is broken so I don't know if I succeeded.

@markusicu

Copy link
Copy Markdown
Member

I've tried to accept the CLA several times but it seems the app is broken so I don't know if I succeeded.

Please try again.

@ianthetechie

Copy link
Copy Markdown
Contributor Author
image

I think it actually worked the last time I guess? When I try going through the form again, after clicking through the first page, I get this at the bottom (it remembers the info from the first time last week) but there is no further button I can press.

@markusicu markusicu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks -- should work either way, but this is more readable

@markusicu markusicu self-assigned this Aug 27, 2026
@jira-pull-request-webhook

Copy link
Copy Markdown

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu

Copy link
Copy Markdown
Member

rebased to recent ICU main to try to get past the msys2 check failure

@markusicu
markusicu merged commit 4f361d9 into unicode-org:main Sep 14, 2026
98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants