Repository navigation
Website: plain pages laid out like the undecuple page; outlined terminal buttons and tabs - #171
Merged
Merged
Conversation
…nal buttons and tabs
…nal buttons and tabs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The plain pages were laid out differently from the undecuple page, and readers who know that page found ours cramped. The terminal view's buttons and tabs had no outline, the legend on the "in action" page had no borders, and the "in action" and "discuss" pages gave no way back to the main page.
Change
in action,discuss).[F1 help],plain view, the command chips) and menu tabs now have a visible outline, as do the four entries of the legend on the "in action" page.site/nav.js: same origin, nothing stored or sent;tools/nav.test.jstests it).tools/site.pygenerates the new blocks;tools/test_site.pyhas tests for the layout, the legend and the detached-page navigation, and checksnav.jsexists. CI's node step runs the nav test. CHANGELOG Docs and tooling: entry; generated site files regenerated.site/style.css, the generator that emits the new blocks and the tests that check them depend on each other, so a part alone would not build or pass--check. The change is 449 changed lines: the stylesheet 118, the generator 77, the tests 106,nav.js31, the generated pages about 115 and the rest small. It is three commits: the restyle, and two merges ofmaininto it (the branch was kept up to date as other changes merged).nav.jsis a same-origin script; the discuss page still alone allows giscus.app, and only after a click).Tests
python3 -m unittest tools.test_site: 46 pass, including the contrast checks for the text colours the new rules use.node --teston the terminal, status, action, discuss and nav tests: 53 pass.python3 tools/features.py,python3 tools/site.py --check,python3 tools/repo_check.pyandscripts/check-deploy.shpass.Not in this change
No change to the terminal view's layout or commands, to the pages' content or to the discussion page's security policy. A discuss command for the terminal view is a separate change. Narrow-screen layouts were not looked at again after merging main.
Overlap
Touches
site/style.css,tools/site.py,tools/test_site.py,.github/workflows/ci.yml, CHANGELOG.md and the generated pages. #169 and the terminal discuss-command change also touch CHANGELOG.md and the generated site files.Developed with AI agent assistance.