Repository navigation
Website: the terminal view has a discuss command and a Discuss menu entry - #170
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The discussion page (
discuss.html) is in the plain pages' menu but not in the terminal view, so a reader who stays in the terminal has no way to it. The terminal already links the "see it in action" page the same way.Change
site/terminal.js: adiscusscommand and a "Discuss" entry in the terminal menu. The command says what the page is and links three places:discuss.html, the Discussions on GitHub and the repository's issues.hrefForaccepts exactlydiscuss.htmlas a same-site link (as it does foraction.html); every other link is still only github.com or a path in the repository. Like the page, the command loads nothing from another site. Tab completion and the help list include it, and its answer is shown asdiscuss.md.tools/terminal.test.js: the new command's links, its file name,hrefForfordiscuss.htmland look-alikes, completion and help; the existing link test acceptsdiscuss.html.Tests
node --teston the four JS test files: 51 pass.python3 -m unittest tools.test_site: 41 pass.python3 tools/features.py,python3 tools/site.py --check,python3 tools/repo_check.pyandscripts/check-deploy.shpass.hrefFornot acceptingdiscuss.html; the page link left as plain text; thediscusscase removed;discussmissing from the command list.discuss.html,https://github.com/undecuple/me/discussions,https://github.com/undecuple/re-psn/issues) under the headerFile: discuss.md; typingdiscand Tab completes todiscuss.Not in this change
The discussion page and its content security policy are unchanged. No change to the plain pages.
Overlap
Touches
site/terminal.js,tools/terminal.test.js, CHANGELOG.md,site/index.htmlandsite/data.json. #169 also changes CHANGELOG.md and the generated site files.Developed with AI agent assistance.