Skip to content

Website: the terminal view has a discuss command and a Discuss menu entry - #170

Merged
undecuple merged 2 commits into
mainfrom
fork-terminal-discuss
Nov 13, 2026
Merged

undecuple merged 2 commits into
mainfrom
fork-terminal-discuss

Conversation

@undecuple

Copy link
Copy Markdown
Owner

Why

The discussion page (discuss.html) is in the plain pages' menu but not in the terminal view, so a reader who stays in the terminal has no way to it. The terminal already links the "see it in action" page the same way.

Change

  • site/terminal.js: a discuss command and a "Discuss" entry in the terminal menu. The command says what the page is and links three places: discuss.html, the Discussions on GitHub and the repository's issues. hrefFor accepts exactly discuss.html as a same-site link (as it does for action.html); every other link is still only github.com or a path in the repository. Like the page, the command loads nothing from another site. Tab completion and the help list include it, and its answer is shown as discuss.md.
  • tools/terminal.test.js: the new command's links, its file name, hrefFor for discuss.html and look-alikes, completion and help; the existing link test accepts discuss.html.
  • CHANGELOG Docs and tooling: entry; the generated site files are regenerated.

Tests

  • node --test on the four JS test files: 51 pass. python3 -m unittest tools.test_site: 41 pass. python3 tools/features.py, python3 tools/site.py --check, python3 tools/repo_check.py and scripts/check-deploy.sh pass.
  • Mutations, each failing a test: hrefFor not accepting discuss.html; the page link left as plain text; the discuss case removed; discuss missing from the command list.
  • In headless Chromium on the built site: the menu lists Discuss; clicking it prints the answer with the three links (discuss.html, https://github.com/undecuple/me/discussions, https://github.com/undecuple/re-psn/issues) under the header File: discuss.md; typing disc and Tab completes to discuss .

Not in this change

The discussion page and its content security policy are unchanged. No change to the plain pages.

Overlap

Touches site/terminal.js, tools/terminal.test.js, CHANGELOG.md, site/index.html and site/data.json. #169 also changes CHANGELOG.md and the generated site files.

Developed with AI agent assistance.

@undecuple
undecuple merged commit 0f1dbb4 into main Nov 13, 2026
10 checks passed
@undecuple
undecuple deleted the fork-terminal-discuss branch November 13, 2026 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant