Repository navigation
Website: .md file names and a full-height file frame in the terminal view - #163
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The terminal view shows each answer as a numbered file, but the name in its header was a bare word (
about,features/planned), and the frame was a short block that left the rest of the pane empty. A file open in a viewer is named like a file and fills its window, with the line-number gutter's rule running to the bottom.Change
site/terminal.js: the name in the header of an answer ends in.md(about.md,features/rooms-basic.md,settings/addr.md,action/punch.md). Only the name changes; no answer's text, no command and no link changes. The frame's accessible name follows it (about.md, 7 lines).site/style.css: the output pane lays its children out in a column; the newest answer's frame grows to fill what is left of the pane, and the gutter rule is drawn down the whole body of the frame. The header row has a little more room.tools/terminal.test.jsexpects the.mdnames;tools/test_site.pyhasFileFrameCssTestfor the fill and rule rules. CHANGELOG Docs and tooling: entry;site/regenerated.Tests
python3 tools/site.py --check,python3 tools/features.py --check,python3 tools/repo_check.py,scripts/check-deploy.sh,python3 -m unittest tools.test_siteand the node tests for terminal, status and action pass, including the contrast tests (the rule is the existing frame colour)..md, the fill rule removed, and a rule that stops halfway each fail a test.mainin headless Chromium: the browser's accessibility tree of the terminal view is the same except for the frame's name (about.md, 7 linesinstead ofabout, 7 lines). The output pane is still a focusable, polite live region named "Output", the menu, the command line and the shortcut buttons keep their names and tab order, and a long answer (the features list) still scrolls in the pane.Not in this change
No new command, no layout change to the menu or the title bar, no change to the plain page.
Overlap
None open that touches
site/terminal.js. Other open work touchesCHANGELOG.md,site/style.cssand the generated site files, so whichever merges later needs a rebase. Based on main at 7fdd762.Developed with AI agent assistance.