This repository was archived by the owner on Feb 16, 2025. It is now read-only.
Quickfix: update coldcard wallet config output to include bip32paths - #49
Merged
waldenraines merged 2 commits intoJan 12, 2021
Conversation
bucko13
reviewed
Jan 11, 2021
Contributor
I'll test the prior version of the firmware, have to downgrade anyway due to a bug in cold card. |
bucko13
reviewed
Jan 11, 2021
bucko13
reviewed
Jan 11, 2021
bucko13
reviewed
Jan 11, 2021
bucko13
left a comment
bucko13
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Sounds like we're leaning towards updating the version number to imply this isn't backwards compatible.
bucko13
approved these changes
Jan 11, 2021
6 tasks
Contributor
|
Old firmware, old config - Works |
waldenraines
approved these changes
Jan 12, 2021
waldenraines
left a comment
waldenraines
left a comment
Contributor
There was a problem hiding this comment.
Everything I tested worked as expected
soralit
pushed a commit
to CoboVault/unchained-wallets
that referenced
this pull request
Jan 18, 2021
…nchained-capital#49) * quickfix: update coldcard wallet config to include bip32paths * swap version to imply this isn't backwards compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coldcard released firmware version 3.2.1 today. It has several multisig updates.
Originally we left out the
Derivationparameter in our wallet config files (even though we had (and still have) access to it via what comes in) because the Coldcard was only paying attention to the first entry forDerivation. And in an effort to alleviate confusion (and because it wasn't a required parameter at the time), we left it out completely and happily continued withDerivation: Unknown.Xpub specific derivations are now supported and
Derivation: Unknownis no longer supported. Added logic to mask out the derivation to the proper depth (included in the xpub itself) if we do not know the bip32path for a particular xpub in the braid.Another major change in the latest firmware update is that multiple xpubs from the same xfp are no longer supported. We had a fixture setup like this, so I updated the fixture.
More line changes than expected because I ran it through prettier.
I expect that we will be integrating changes from #44 soon, but I wanted to go ahead and submit a solution to the current situation. I believe this does it. If you use the older firmware, it will only look at the first derivation path, but I believe that will be okay.