fix: match routes on canonical escaped paths - #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @paskal.
matchHandlerchose the route usingr.URL.EscapedPath(), the path exactly as the client wrote it, while the director forwards the canonical form. Any character that re-encodes to itself is silently dropped between the routing decision and the forwarded request, so a route regex was evaluated against a string the upstream never sees.Encoding one character of a protected prefix was enough to miss the protected route, match a wider one, be checked against the wider route's policy, and still arrive at the protected upstream path. It is not specific to
%2F:/api/%70rivate/secretworks the same way.Matching now runs on the canonical escaped path, so the routing decision and what the upstream resolves are the same string. Verified against built binaries with a route behind
auth:and a wider route into the same namespace:The
%20and%25pass-through is byte-identical to master, so the behaviour the existing regression test locks in is untouched.