Skip to content

Drop the legacy build tag line - #65

Merged
umputun merged 1 commit into
umputun:masterfrom
paskal:chore/go-fix-build-tag
Aug 20, 2026
Merged

Drop the legacy build tag line#65
umputun merged 1 commit into
umputun:masterfrom
paskal:chore/go-fix-build-tag

Conversation

@paskal

@paskal paskal commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The result of go fix ./..., left over from #63. app/syslog/syslog_windows.go carried both constraint forms; the // +build line has been ignored since Go 1.18 and the module requires 1.26, so only the //go:build line is needed. Verified with GOOS=windows go build ./... and GOOS=linux go build ./....

Result of go fix, the // +build form has been ignored since Go 1.18.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 32347537553

Coverage remained the same at 79.633%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 491
Covered Lines: 391
Line Coverage: 79.63%
Coverage Strength: 27.02 hits per line

💛 - Coveralls

@umputun
umputun merged commit 4809758 into umputun:master Aug 20, 2026
4 checks passed
@paskal
paskal deleted the chore/go-fix-build-tag branch August 20, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants