chore: update golangci-lint to 2.12.2 - #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
GOLANGCIpin has been at 2.9.0 since February, while the images that consume this base pin newer versions in their own workflows. That gap stayed invisible becausebuildgo-latestwas not rebuilt for months. When it was rebuilt yesterday, every consumer received the accumulated jump at once, and secrets went red: its Dockerfile lints with the base image while its workflow lints with v2.12.2, and the two versions disagree in both directions.Concretely, gosec at 2.12.2 emits G124, G705 and G118 at sites where 2.9.0 does not, so suppressions required by one version read as unused to the other. No arrangement of
//nolintcomments satisfies both whilenolintlintis enabled.Bumping the pin to 2.12.2 removes the split rather than working around it in each consumer. Verified by running golangci-lint 2.12.2 against unmodified secrets master: 0 issues, so that repository needs no change of its own once this image is rebuilt.
One line.
GORELEASER,GOVERALLS,STATIK, the Go base tag and the other two image directories are untouched.