Skip to content

Feat/utm link builder - #4493

Open
MontejoJorge wants to merge 9 commits into
umami-software:devfrom
MontejoJorge:feat/utm-link-builder
Open

MontejoJorge wants to merge 9 commits into
umami-software:devfrom
MontejoJorge:feat/utm-link-builder

Conversation

@MontejoJorge

@MontejoJorge MontejoJorge commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

This PR adds a modal to build the utm links

image image

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

NoiceHax and others added 8 commits August 13, 2026 22:43
The trailing-slash regex also matched the leading slash of the root URL, so with REMOVE_TRAILING_SLASH set every home page view was stored with an empty url_path: the home page vanished from the paths/entry/exit reports and could not be selected as a funnel step. Skip the match at the start of the path so "/" and "/#hash" are preserved while "/blog/" and "/blog/#hash" are still trimmed.

Closes umami-software#4152
fix(send): keep the root path when REMOVE_TRAILING_SLASH is enabled
@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@MontejoJorge is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR adds a modal UTM-link builder to the website UTM report and introduces the corresponding English labels.

  • Adds fields for destination, campaign, content, medium, source, and term.
  • Generates a copyable URL from the website domain or an absolute destination.
  • Adds a report-header button that opens and closes the builder dialog.

Confidence Score: 3/5

The PR should not merge until the source-field binding and fragment-aware URL construction are corrected.

The builder currently generates incorrect attribution links for every entered source value and for valid destinations containing URL fragments.

Files Needing Attention: src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx

Important Files Changed

Filename Overview
src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx Adds the URL builder, but the Source field updates the wrong state and fragment-bearing destinations produce unusable campaign parameters.
src/app/(main)/websites/[websiteId]/(reports)/utm/UTM.tsx Adds the dialog trigger to the UTM report without an independently identified defect.
src/components/messages.ts Registers the three new translation label keys.
public/intl/messages/en-US.json Adds English copy for the generator, destination, and generated URL labels.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Report[UTM report] --> Button[UTM Link generator button]
  Button --> Dialog[Builder dialog]
  Website[Website domain] --> Builder[URL builder]
  Inputs[Destination and UTM fields] --> Builder
  Builder --> Output[Copyable generated URL]
  Dialog --> Inputs
  Dialog --> Output
Loading

Reviews (1): Last reviewed commit: "change icon, close btn, and fix field or..." | Re-trigger Greptile

Comment thread src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx Outdated
Comment thread src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@MontejoJorge
MontejoJorge changed the base branch from master to dev August 27, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants