Feat/utm link builder - #4493
Open
MontejoJorge wants to merge 9 commits into
Open
MontejoJorge wants to merge 9 commits into
MontejoJorge wants to merge 9 commits into
Conversation
The trailing-slash regex also matched the leading slash of the root URL, so with REMOVE_TRAILING_SLASH set every home page view was stored with an empty url_path: the home page vanished from the paths/entry/exit reports and could not be selected as a funnel step. Skip the match at the start of the path so "/" and "/#hash" are preserved while "/blog/" and "/blog/#hash" are still trimmed. Closes umami-software#4152
fix(send): keep the root path when REMOVE_TRAILING_SLASH is enabled
|
@MontejoJorge is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR adds a modal UTM-link builder to the website UTM report and introduces the corresponding English labels.
Confidence Score: 3/5The PR should not merge until the source-field binding and fragment-aware URL construction are corrected. The builder currently generates incorrect attribution links for every entered source value and for valid destinations containing URL fragments. Files Needing Attention: src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx
|
| Filename | Overview |
|---|---|
| src/app/(main)/websites/[websiteId]/(reports)/utm/BuildUTMLink.tsx | Adds the URL builder, but the Source field updates the wrong state and fragment-bearing destinations produce unusable campaign parameters. |
| src/app/(main)/websites/[websiteId]/(reports)/utm/UTM.tsx | Adds the dialog trigger to the UTM report without an independently identified defect. |
| src/components/messages.ts | Registers the three new translation label keys. |
| public/intl/messages/en-US.json | Adds English copy for the generator, destination, and generated URL labels. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart LR
Report[UTM report] --> Button[UTM Link generator button]
Button --> Dialog[Builder dialog]
Website[Website domain] --> Builder[URL builder]
Inputs[Destination and UTM fields] --> Builder
Builder --> Output[Copyable generated URL]
Dialog --> Inputs
Dialog --> Output
Reviews (1): Last reviewed commit: "change icon, close btn, and fix field or..." | Re-trigger Greptile
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a modal to build the utm links
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.