feat: make ClickHouse connection limit configurable - #4492
Open
arthurbragaa wants to merge 2 commits into
Open
arthurbragaa wants to merge 2 commits into
arthurbragaa wants to merge 2 commits into
Conversation
Implemented and tested with AI assistance; reviewed by Arthur Braga.
|
@arthurbragaa is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR makes the ClickHouse client connection limit configurable while retaining the client default when unset.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/lib/clickhouse.ts | Gates connection-limit parsing on ClickHouse being enabled and conditionally forwards the validated value to the client. |
| scripts/check-db.js | Validates the optional limit only after the preflight skip and only for enabled ClickHouse deployments. |
| src/lib/clickhouse.test.ts | Covers defaults, configured limits, invalid values, and disabled ClickHouse behavior. |
| README.md | Documents the option, current client default, and per-instance pool sizing. |
Reviews (2): Last reviewed commit: "fix: ignore ClickHouse limit when disabl..." | Re-trigger Greptile
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLICKHOUSE_MAX_OPEN_CONNECTIONSconfigurationCloses #4491.
Verification
pnpm test— 95 files, 748 testspnpm exec tsc --noEmitpnpm build25peaked at 25 with 50/50 successful/api/sendrequests; invalid0exited before health startupFull
pnpm lintremains blocked by pre-existing diagnostics ondev; the changed files pass Biome.AI assistance disclosure: This contribution was implemented and tested with AI assistance and reviewed by Arthur Braga Alfredo.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.