Conversation
|
@Yashh56 is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR adds previous/next controls and arrow-key navigation to replay playback, backed by the replay rows on the active table page.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| src/app/(main)/websites/[websiteId]/replays/ReplaysTable.tsx | Publishes the visible standard replay rows to the shared navigation store. |
| src/app/(main)/websites/[websiteId]/replays/SavedReplaysTable.tsx | Publishes saved replay rows while retaining their visit identifiers for playback navigation. |
| src/app/(main)/websites/[websiteId]/replays/[replayId]/ReplayPlayback.tsx | Adds adjacent replay buttons and keyboard shortcuts, with identifier selection compatible with both table row shapes. |
| src/store/replays.ts | Adds ephemeral shared Zustand state for the replay rows currently available to modal navigation. |
Sequence Diagram
sequenceDiagram
participant T as Replay table
participant S as Replay store
participant M as Playback modal
participant R as Router
T->>S: Store visible replay rows
T->>R: Open selected visit ID
R->>M: Set replay query parameter
M->>S: Find current and adjacent rows
M->>R: Navigate using adjacent visit ID
Reviews (2): Last reviewed commit: "fix(replays): use visitId over id for sa..." | Re-trigger Greptile
Contributor
Author
Contributor
Author
|
Hey @franciscao633, Can you please review this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
What does this PR do?
This PR adds the ability to seamlessly navigate between consecutive session replays directly from the playback modal, without needing to close it and return to the data table.
Changes included:
useReplaysZustand store (src/store/replays.ts) to track the list of replays currently being viewed on the active page (works for both the standard Replays table and the Saved Replays table).ChevronLeft) and "Next" (ChevronRight) action buttons to theReplayPlaybackheader. These automatically disable when the user reaches the beginning or end of the visible list.ArrowLeftandArrowRightkeyboard navigation inside the modal to quickly jump between adjacent replays. The event listener is attached via the capture phase to bypass any potential focus traps, and prevents default action to avoid conflicting with therrweb-player's internal seeking controls.Closes: #4416
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.