Skip to content

fix(terminal): don't let onResize force a size report #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AThraen merged 1 commit into from
Sep 30, 2026
Merged

fix(terminal): don't let onResize force a size report #145

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/CodeShellManager/Assets/terminal-init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,13 @@

// Still worth keeping alongside doFit(): a resize can also originate inside the
// terminal (CSI 8 t) rather than from a fit of ours.
term.onResize(postSize);
//
// Wrapped, for the same reason the ResizeObserver, requestAnimationFrame and
// document.fonts.ready sites are: xterm hands the listener a {cols, rows} object, which
// as a bare reference arrives as postSize's `force` and is truthy — so this one call
// site silently bypassed the duplicate-size check that force exists to override only
// for an options ack.
term.onResize(function () { postSize(); });

term.open(document.getElementById('terminal'));
doFit();
Expand Down