Skip to content

Accept normalized CLA signature comments - #10

Merged
glenn-jocher merged 1 commit into
masterfrom
cla-signature-gate-20260828
Aug 28, 2026
Merged

glenn-jocher merged 1 commit into
masterfrom
cla-signature-gate-20260828

Conversation

@glenn-jocher

@glenn-jocher glenn-jocher commented Aug 28, 2026 •

Copy link
Copy Markdown
Member

Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.

This makes only the signature gate permissive. The recheck command remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.

Related matcher fix: ultralytics/actions#894

Validation:

  • actionlint .github/workflows/cla.yml
  • npx prettier@3.8.5 --check .github/workflows/cla.yml

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Updated the CLA workflow to pass comments containing the valid signature text to the action matcher, allowing surrounding Markdown or trailing whitespace to be normalized before validation.

📊 Key Changes

  • Changed the signature condition in .github/workflows/cla.yml from exact equality to contains(...).
  • Kept the recheck comment condition as an exact match.
  • Left final signature validation to the existing action matcher, which determines whether the normalized content is valid.

🎯 Purpose & Impact

  • Valid CLA comments with surrounding Markdown or trailing whitespace can now reach the normalized signature matcher instead of being rejected by the workflow gate.
  • Quoted or instructional text is not automatically treated as a signature; the action matcher still performs the final validation.

@UltralyticsAssistant UltralyticsAssistant added the bug Something isn't working label Aug 28, 2026
@UltralyticsAssistant

Copy link
Copy Markdown
Member

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/yoloe_data_engine 🚀 PR! This automated message confirms your contribution was received, and an Ultralytics engineer will assist with the review. To ensure a seamless integration of your work, please review the following checklist:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/yoloe_data_engine main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

@UltralyticsAssistant UltralyticsAssistant left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

Reviewed the .github/workflows/cla.yml condition and its interaction with the normalized CLA matcher. The permissive signature gate allows valid formatted comments to reach the action, while recheck remains exact as intended; non-signature mentions are rejected by the action itself. LGTM.

@glenn-jocher
glenn-jocher merged commit 89c1e1a into master Aug 28, 2026
5 checks passed
@glenn-jocher
glenn-jocher deleted the cla-signature-gate-20260828 branch August 28, 2026 10:25
@UltralyticsAssistant

Copy link
Copy Markdown
Member

🎉 PR #10 was merged—thank you, @glenn-jocher!

“The details are not the details. They make the design.” — Charles Eames

This thoughtful workflow refinement ensures valid CLA comments with surrounding Markdown or trailing whitespace reach the normalized signature matcher, while final validation remains unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants