Accept normalized CLA signature comments - #46
Conversation
|
👋 Hello @glenn-jocher, thank you for submitting a
For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀 |
UltralyticsAssistant
left a comment
There was a problem hiding this comment.
🔍 PR Review
Made with ❤️ by Ultralytics Actions
LGTM. The workflow gate is intentionally broadened only for signature-comment detection, while the exact recheck command remains unchanged. The action retains responsibility for validating a normalized signature line, so surrounding instructional or quoted text does not sign the CLA.
|
🎉 This PR has been merged—thank you, @glenn-jocher!
This focused CLA workflow update allows comments containing valid signature phrases—including trailing whitespace or surrounding Markdown—to reach normalized validation, while preserving exact |
Valid CLA signature comments with trailing whitespace or surrounding Markdown currently never reach the normalized action matcher because the workflow gate requires exact equality.
This makes only the signature gate permissive. The
recheckcommand remains exact, and the action still decides whether a single normalized line is a valid signature, so quoted or instructional text does not sign the CLA.Related matcher fix: ultralytics/actions#894
Validation:
actionlint .github/workflows/cla.ymlnpx prettier@3.8.5 --check .github/workflows/cla.yml🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Updated the CLA workflow to pass comments containing the valid signature phrase to the normalized action matcher instead of requiring exact comment equality.
📊 Key Changes
.github/workflows/cla.ymlfrom exact equality tocontains(...).recheckcommand matched by exact equality.🎯 Purpose & Impact