Skip to content

Highlight scanner warnings on log line fields - #304

Open
ultimate wants to merge 5 commits into
mainfrom
codex/highlight-problematic-fields-with-tooltip
Open

Highlight scanner warnings on log line fields#304
ultimate wants to merge 5 commits into
mainfrom
codex/highlight-problematic-fields-with-tooltip

Conversation

@ultimate

Copy link
Copy Markdown
Owner

Motivation

  • Scanner results currently present many warnings in a single block which are hard to match to specific log lines or fields.
  • The goal is to make it easier to find problematic fields by linking warnings to table cells and surfacing the warning text as a tooltip.

Description

  • Add indexScannerWarnings in app/lib/logbook-scanner/warning-fields.ts to parse persisted scanner warning strings and map row-level warnings to affected LineFormField entries while keeping sheet-level and unassignable warnings separate.
  • Wire the index into the UI in app/components/logbook/pages/LogbookDetailsPage.tsx, compute noticeScannerWarnings, and add scannerWarningCellProps to attach title/aria-label and a scanner-warning-field class to affected <td> cells.
  • Add styling in app/globals.css for .log-lines-table td.scanner-warning-field including hover feedback to visually highlight problematic cells.
  • Add unit tests tests/app/lib/logbook-scanner-warning-fields.test.ts for the indexing logic and update the E2E test tests/e2e/logbook-scanner.spec.ts to assert a scanned warning highlights the matching latitude cell.

Testing

  • Ran the unit test: npx vitest run tests/app/lib/logbook-scanner-warning-fields.test.ts which passed (2 tests).
  • Ran type checking: npm run typecheck (tsc --noEmit) which succeeded.
  • Ran the targeted E2E scenario via Playwright: npx playwright test tests/e2e/logbook-scanner.spec.ts --grep "imports a scanned" which passed (1 test).
  • Ran npm run lint which produced existing, unrelated lint warnings/errors in other files (no new lint errors introduced by these changes).

Codex Task

@ultimate ultimate added the codex Things in relation to codex (caused by codex or good task for codex) label Aug 28, 2026 — with ChatGPT Codex Connector
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ultilog Ready Ready Preview Aug 30, 2026 2:26pm

@ultimate

Copy link
Copy Markdown
Owner Author

Implements #309 and #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex Things in relation to codex (caused by codex or good task for codex)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant