Skip to content

use npm for scripts#94

Merged
Nealium104 merged 2 commits into
mainfrom
92-exploreuk-build-uses-npx-for-lightningcss-and-not-installed-package
Apr 3, 2026
Merged

use npm for scripts#94
Nealium104 merged 2 commits into
mainfrom
92-exploreuk-build-uses-npx-for-lightningcss-and-not-installed-package

Conversation

@Nealium104

@Nealium104 Nealium104 commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

This PR replaces the minify.sh script with a short invocation of lightningcss using npm to ensure that our versions of packages will be ran consistently.

fixes #92

@Nealium104 Nealium104 requested a review from cokernel April 3, 2026 13:50
cokernel
cokernel previously approved these changes Apr 3, 2026

@cokernel cokernel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashless.

@cokernel

cokernel commented Apr 3, 2026

Copy link
Copy Markdown
Member

I did not catch the merge conflicts.

…-and-not-installed-package, add comment for clarity

@cokernel cokernel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Nealium104 Nealium104 merged commit fc6c3c4 into main Apr 3, 2026
3 checks passed
@Nealium104 Nealium104 deleted the 92-exploreuk-build-uses-npx-for-lightningcss-and-not-installed-package branch April 3, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExploreUK build uses npx for lightningcss and not installed package

2 participants