Make .gitmodules protocol-agnostic.#91
Merged
Merged
Conversation
It's still implicitly tied to a specific platform, though.
Member
Author
|
Verified correct behavior when cloning via SSH. (edited to clarify actual protocol) |
Member
Author
|
@Nealium104 , could you look at the HTTPS case? |
Contributor
|
From a clean pull and checkout of this PR (with appropriate redactions): # check protocol
$ gh auth status
github.com
Logged in to github.com account Nealium104
...
- Git operations protocol: https
...
# submodule commands from README.md
$ git submodule init; git submodule update
Submodule 'assets/frontpage-assets' (https://github.com/uklibraries/exploreuk-frontpage-assets.git) registered for path 'assets/frontpage-assets'
Cloning into '/home/neal/workspaces/test/exploreuk-web-app/assets/frontpage-assets'...
Submodule path 'assets/frontpage-assets': checked out '29b03c47331230d35d521caee012e7a28d93b1d9'Looks good to me! |
Nealium104
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #90.
It's still implicitly tied to a specific platform, though.