Add fallback language support in get_template with try/catch error ha…#516
Open
yakov-sudo wants to merge 1 commit into
Open
Add fallback language support in get_template with try/catch error ha…#516yakov-sudo wants to merge 1 commit into
yakov-sudo wants to merge 1 commit into
Conversation
…ndling Fixes ui#515 This PR wraps template retrieval logic in try/catch blocks so that: - If a translated template lookup fails via translated_templates.get(), the original template is kept - If get_email_template() fails for a specific language, it falls back to getting the template without language This prevents the entire email sending operation from failing when a translation is unavailable.
Collaborator
|
Hey, sorry but I actually don't quite agree with this change. I think the current behavior of raising an exception is correct so the exception can be handled by the user. If you feel strongly, we can add an argument that alters the behavior such that it returns the original template if the translation is not found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ndling
Fixes #515
This PR wraps template retrieval logic in try/catch blocks so that:
This prevents the entire email sending operation from failing when a translation is unavailable.