Sympy#2
Open
Margus2004 wants to merge 9 commits into
Open
Conversation
…n for adjusting scan pixel pitch *sympy based functions: scale(), rotate(), flip_y(), identity(), scale_rotate_flip() Use sympy functions to calculate sin(), cos() etc. *generalized function: find a general expression for DescanError while adjusting scan pixel pitch, then convert it to a function for insertinf values and construct new model *comments: + exchange jnp by np in Parameters4DSTEM for xp value, as symbols are not jax-compatible + comment out some assertions with comparisons, as arbitrary symbols compared to a number are undetermined
* Cached class method to generate adjustment function with SymPy * Distinguish docstring for end users from comments for developers * A few simplifications * Add simplify to scale_rotate_flip()
…adjust_scan_pixel_pitch() * Simplify symbol declaration through symbol_maker() * Assign symbols to parameters using symbol_maker() in _mk_adjust_scan_pixel_pitch() * Some simplifications in _mk_adjust_scan_pixel_pitch()
Closed
…just_detector_pixel_pitch() *The added functions work exactly on the way as the previously added _mk_adjust_scan_pixel_pitch() *_mk_adjust_scan_rotation() does not use rotate(), but depends only on sympy solution of the equation *Due to type issues it stops at scale_rotate_flip() in params method: the values of the angles become too inaccurate to be compared correctly
Lambdify function that can accept any Jax-compatble trees to specify inputs and outputs. Different from the sympy lambdify, this lambdifies a function.
Include postfix
...and don't allow generating symbols for unknown types, instead restrict to numeric types
* Normalize function arguments * Generate defaults if inputs are not supplied * TODO integrate in main source, started with not calling function but using supplied result in sympy interface part * Convenient decorator
Work with David: multivariative taylor expansion implementation and Lens and propagate functions test to work with sympy
Owner
|
Keeping this open for now, will likely close at some point as soon as we are sure everything is migrated to https://github.com/uellue/Microscope-Calibration/tree/sympysimplify and TemGym. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.