test: control lazy recovery timing - #134
Merged
Merged
Conversation
|
🎉 This PR is included in version 0.11.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS main run 34714681380 checked document recovery after a 10 ms wall-clock wait and saw no navigation yet. Advance a fake clock through import rejection and the scheduled handoff so the recovery assertions do not depend on runner timing.
Changes
FakeTimethroughout the eight lazy-route recovery tests.Testing
deno task checkpassed;deno task test --parallel --reporter=dotpassed (34 suites, 388 steps).deno task test --reporter=dot client.test.tsx, with only the delayed-import case selected and the original 10 ms helper, failed atassertEquals(assigned, ["/destination?q=1#top"]): actual[].deno task test --reporter=dot --filter 'createLazyRoute failure recovery' client.test.tsxpassed all eight cases with the clock fix.assertPendingRecovery: actualresolved, expectedpending. The mutation was restored before the full gates.Closes
Nothing.