Repository navigation
Fix vgrid share access with wsgidav-4.3.5+ - #689
Conversation
`MiGFilesystemProvider` constructor call to re-enable access to linked vgrid shared folders with wsgidav-4.3.5+ where it broke due to a security fix for: GHSA-wm65-64rq-rh8r We already implement and enforce our own chrooting of the symlinked paths so the fixed issue should not matter in our setup. Apply a few trivial lint fixes while at it.
|
The failed actions are duplicate of unrelated lint issues in #338 . |
|
A small thing, the link provided by https://wsgidav.readthedocs.io/en/4.3.5/_autosummary/wsgidav.fs_dav_provider.FilesystemProvider.html#wsgidav.fs_dav_provider.FilesystemProvider does not appear to be stable for a particular version such as 4.3.5, instead either 'latest' or 'stable' can be used such as https://wsgidav.readthedocs.io/en/stable/_autosummary/wsgidav.fs_dav_provider.FilesystemProvider.html |
Alright, I manually pointed to that version to avoid silent version slip, but thanks for pointing it out. |
Enable
follow_symlinksoption indaemon_confand pass it through theMiGFilesystemProviderconstructor call to re-enable access to symlinked vgrid shared folders with wsgidav-4.3.5+, where it broke along with the security fix for:GHSA-wm65-64rq-rh8r
The
follow_symlinksoption is documented athttps://wsgidav.readthedocs.io/en/latest/user_guide_configure.html
and used as explained on
https://wsgidav.readthedocs.io/en/4.3.5/_autosummary/wsgidav.fs_dav_provider.FilesystemProvider.html#wsgidav.fs_dav_provider.FilesystemProvider
We already implement and enforce our own chrooting of the symlinked paths, so the fixed issue should not matter in our setup.
Apply a few trivial lint fixes while at it.