Delete cloud instances if they are created but a subsequent step failed - #652
Merged
rasmunk merged 5 commits intoSep 9, 2026
Merged
Conversation
… process failed, but the instance itself was created. This enables the user to later manage the created instance
jonasbardino
reviewed
Sep 9, 2026
jonasbardino
left a comment
jonasbardino
left a comment
Contributor
There was a problem hiding this comment.
I'd say the proper fix is to delete such broken instances directly as the user cannot use them and we don't want them left behind taking up resources.
…reation failed, which will also potentially remove the associated floating point IP that may be lingering
Contributor
Author
|
That can also be the approach, either way as long as we ensure that if |
rasmunk
changed the title
Contributor
Author
|
Have adjusted the commit such that it now tries to delete the instance after |
jonasbardino
reviewed
Sep 9, 2026
|
|
||
| client_id = ' ME ' | ||
| cloud_is = 'mist' | ||
| cloud_id = 'mist' |
Contributor
Author
There was a problem hiding this comment.
It was the linter who was not happy about that:)
jonasbardino
reviewed
Sep 9, 2026
jonasbardino
approved these changes
Sep 9, 2026
jonasbardino
added
bug
jonasbardino
added this to the
Python3 support for general research data sites milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As highlighed in #653 . This PR aims to fix this issue by saving the cloud instance if it was created but the overall creation failed such that the user can later manage it