fix: remove hard-coded colors from Mermaid diagrams for dark mode readability#702
Open
rkratky wants to merge 2 commits into
Open
fix: remove hard-coded colors from Mermaid diagrams for dark mode readability#702rkratky wants to merge 2 commits into
rkratky wants to merge 2 commits into
Conversation
rkratky
requested review from
MylesJP,
RAOF,
athos-ribeiro,
basak,
bdrung,
cpaelzer,
didrocks,
enr0n,
joalif,
julian-klode,
lvoytek,
panlinux,
pushkarnk,
s-makin,
setharnold,
tjaalton and
utkarsh2102
as code owners
July 14, 2026 12:25
Collaborator
Author
|
Note for reviewers: This PR does not change any content -- it only improves styling and formatting of diagrams. No text, incl. in the diagrams has been touched. |
enr0n
approved these changes
Jul 14, 2026
cpaelzer
approved these changes
Jul 14, 2026
cpaelzer
left a comment
Collaborator
There was a problem hiding this comment.
+1 for the changes to the MIR pages, checked the rendering on https://canonical-ubuntu-projectubuntu--702.com.readthedocs.build/MIR/mir-process-states/ and it is fine.
setharnold
reviewed
Jul 14, 2026
setharnold
left a comment
Collaborator
There was a problem hiding this comment.
Is ISSUES-ASSESSMENT.md supposed to be part of this? it feels like it's intended for your own local use.
Collaborator
Author
Yeah, that's an oversight, of course. Thanks. Fixed now. |
utkarsh2102
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fill,stroke,background,classDef,style) from all Mermaid diagrams so they use the default theme, which adapts to both light and dark modesthemeVariables(fontSize,fontFamily) to each diagram to maintain consistent typography without hard-coding colorscustom_styles.cssfrom 70% to 100%Related issue
Checklist