Ubuntu patches DEP-3 header related adjustments#653
Open
athos-ribeiro wants to merge 5 commits into
Open
Conversation
The "backport" value in the Origin DEP-3 field should be used to inform that the patch was retrieved from the upstream project and adjusted to be applied to the current Ubuntu package version.
If dropping the quit headers is indeed desired, it should be proposed in quilt itself. The reason some Debian Developers do not use that header is that they do not use quilt to manage their patches.
The DEP-3 Bug-Ubuntu field should always be used when a patch is addressing an existing launchpad bug. Let's drop this documentation bit which may suggest otherwise.
The "no" value should be used whenever the patch was "not yet" forwarded, whereas the "not-needed" value should be used when the change is vendor specific.
athos-ribeiro
requested review from
basak,
bdrung,
cpaelzer,
enr0n,
lvoytek and
utkarsh2102
June 23, 2026 17:02
Contributor
|
I'm happy with the Rust docs changes. |
Collaborator
|
Good already, could I ask you to Could we have a table in https://ubuntu.com/project/docs/how-ubuntu-is-made/concepts/deb-3-patch-file-headers/ about all the combinations we can think of: column 1 - change in file.c, debian/rules, debian/patches/foo.patch Asd anything you can tihnk of, I'm not sure where the following fits:
|
rkratky
reviewed
Jul 13, 2026
rkratky
left a comment
rkratky
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, @athos-ribeiro! Just a couple of nitpicks.
| In order to fix certain bugs, it's likely you'll need to create your own patch at some point. It's important that this patch contains enough information for other people to understand _what_ it's doing and _why_ it's doing it. | ||
|
|
||
| First, ensure that [Debian](https://salsa.debian.org/rust-team/rust/-/tree/debian/experimental?ref_type=heads) has not already created an equivalent patch. If so, you can simply use their patch directly. If you need to modify the patch in any way, make sure to add `Origin: backport, <Debian VCS patch URL>` to the patch header. | ||
| First, ensure that neither the upstream project nor [Debian](https://salsa.debian.org/rust-team/rust/-/tree/debian/experimental?ref_type=heads) has already created an equivalent patch. If so, you can simply use their patch directly. In such cases, make sure to include [DEP-3](https://dep-team.pages.debian.net/deps/dep3/) headers when appropriate. |
Collaborator
There was a problem hiding this comment.
Suggested change
| First, ensure that neither the upstream project nor [Debian](https://salsa.debian.org/rust-team/rust/-/tree/debian/experimental?ref_type=heads) has already created an equivalent patch. If so, you can simply use their patch directly. In such cases, make sure to include [DEP-3](https://dep-team.pages.debian.net/deps/dep3/) headers when appropriate. | |
| First, ensure that neither the upstream project nor [Debian](https://salsa.debian.org/rust-team/rust/-/tree/debian/experimental?ref_type=heads) has already created an equivalent patch. If so, use their patch directly. In such cases, make sure to include [DEP-3](https://dep-team.pages.debian.net/deps/dep3/) headers when appropriate. |
| useful for vendor-specific patches. | ||
| : Information about how the patch was sent to the upstream project in case it | ||
| was not originated from there. When present, this should be a URL proving | ||
| that the patch was forwarded (e.g., a Pull Request or a patch in a bug |
Collaborator
There was a problem hiding this comment.
Suggested change
| that the patch was forwarded (e.g., a Pull Request or a patch in a bug | |
| that the patch was forwarded (e.g., a pull request or a patch in a bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the dep3 headers to avoid confusion on its usage. In special, see https://lists.ubuntu.com/archives/ubuntu-devel-discuss/2026-June/019806.html