Skip to content

moveHandler: Remove the monitor grace period timer when a grab ends #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aleasto merged 2 commits into from
Sep 11, 2026
Merged

moveHandler: Remove the monitor grace period timer when a grab ends #461

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbf6c92
moveHandler: Remove the monitor grace period timer when a grab ends
PhilMeyr Sep 10, 2026
730fdd9
moveHandler: Don't log an error when a dragged window is destroyed
PhilMeyr Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions tiling-assistant@leleat-on-github/src/extension/moveHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,12 @@ export default class TilingMoveHandler {

_onMoveFinished(window) {
try {
window.assertExistence();
// Ignore the expected error when the window was destroyed during the grab.
try {
window.assertExistence();
} catch {
return;
}

if (this._tileRect) {
// Ctrl-drag to replace some windows in a tile group / create a new tile group
Expand Down Expand Up @@ -293,6 +298,12 @@ export default class TilingMoveHandler {
this._dragSprite = null;
}
} finally {
// Leaving it pending would re-enter _edgeTilingPreview() on a destroyed window
if (this._latestMonitorLockTimerId) {
GLib.Source.remove(this._latestMonitorLockTimerId);
this._latestMonitorLockTimerId = null;
}

if (this._posChangedId) {
window.disconnect(this._posChangedId);
this._posChangedId = 0;
Expand Down Expand Up @@ -497,7 +508,8 @@ export default class TilingMoveHandler {
// Only update the monitorNr, if the latest timer timed out.
if (timerId === this._latestMonitorLockTimerId) {
this._monitorNr = global.display.get_current_monitor();
if (global.display.is_grabbed())
// check that the window still exists, and a grab is still active
if (global.display.is_grabbed() && window.get_compositor_private())
this._edgeTilingPreview(window, grabOp);
}

Expand Down
Loading