Repository navigation
Conversation
With digits set, negative values were padded as a whole string, so -3
with digits: 4 was displayed as "00-3". That text is not a number:
typing could not continue from it, and a +/- step threw a
FormatException when the padded text was parsed for onSubmitted.
Pad only the magnitude and keep the sign first ("-003").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With
digits, -3 was displayed as00-3. That text is not a number: the value parsed as 0, and a +/- step threw aFormatExceptionwhen building theonSubmittedvalue.Fix
Pad only the magnitude, so -3 shows as
-003.Tests
test/negative_value_padding_test.dart.CI on
maincurrently fails in the Android example build and the publish dry-run; it goes green with #102.