Repository navigation
Conversation
CupertinoSpinBox always passed a Row as the text field's prefix and suffix, even when it was empty (buttons hidden or vertical layout and no custom prefix/suffix). CupertinoTextField then built and laid out the adornment slots for nothing. Build the Row only when horizontal buttons need reserved space; otherwise pass the caller's prefix/suffix (or null) directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CupertinoSpinBoxalways passedRowwidgets as prefix/suffix, even when they were empty (buttons hidden, or vertical layout).Fix
Build the
Rowonly when horizontal buttons need reserved space; otherwise pass the caller's prefix/suffix, ornull. Geometry is unchanged in all button modes, LTR and RTL.Tests
test/cupertino_spinbox_layout_test.dart.CI on
maincurrently fails in the Android example build and the publish dry-run; it goes green with #102.