GitHub Actions CI: Remove Zig in Python wheel release#315
GitHub Actions CI: Remove Zig in Python wheel release#315jayaddison wants to merge 1 commit intoua-parser:masterfrom
Conversation
The Zig toolchain functionality enabled here originates from a build workflow[1] in the `uap-rust` repository; as far as I can tell, Zig is not required when building and releasing the Python wheels. My understanding is that the `maturin-action` that installs the Zig dependencies would proceed[2] even if they cannot be installed, so I don't think that their failure would block the release process here. Even so, I think that software build processes should usually try to limit their build requirements to only what is necessary, so I'm offering this as a cleanup. Resolves ua-parser#312. [1] - ua-parser/uap-rust#3 [2] - https://github.com/PyO3/maturin-action/blob/04ac600d27cdf7a9a280dadf7147097c42b757ad/dist/index.js#L47396-L47407
|
@masklinn hm. re-reading the It looks like the CI job assigns various native build runners from a matrix of options -- so I don't know whether we need the overhead (and extra surface area) of a Docker build. One idea would be to explicitly configure |
That was never intended, so doesn't matter.
The question is less whether we need the overhead and more whether we need to avoid it. The wheels workflow doesn't run normally, only when the PR is flagged to run it or when cutting a release, so it doesn't matter. |
|
Although it does look like the dockerised maturin is not happy: https://github.com/ua-parser/uap-python/actions/runs/25629265798/job/75229894764#step:5:262 |
The Zig toolchain functionality enabled here originates from a build workflow in the
uap-rustrepository; as far as I can tell, Zig is not required when building and releasing the Python wheels.My understanding is that the
maturin-actionthat installs the Zig dependencies would proceed even if they cannot be installed, so I don't think that their failure would block the release process here.Even so, I think that software build processes should usually try to limit their build requirements to only what is necessary, so I'm offering this as a cleanup.
Resolves #312.